Re: vacuum hint on elog

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: vacuum hint on elog
Date: 2005-01-22 12:56:33
Message-ID: 20050122125633.GA31867@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sat, Jan 22, 2005 at 11:28:52PM +1100, Neil Conway wrote:
> It occurred to me that if we elog(ERROR) during VACUUM, the vacuum
> activity hint will not be reset. This will result in all subsequent I/O
> by the current backend being treated by the bufmgr as though it resulted
> from VACUUM. While elog(ERROR) during VACUUM is not a common occurrence,
> I don't think it's wise to assume it is impossible.

Hmm ... I think you should rather use a PG_TRY/PG_CATCH block. (Or
discover whether this is already done somewhere else ...)

--
Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
"El día que dejes de cambiar dejarás de vivir"

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-01-22 13:24:50 Re: vacuum hint on elog
Previous Message Neil Conway 2005-01-22 12:28:52 vacuum hint on elog