Re: pgsql: Fix for Unicode characters above 0x10000.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix for Unicode characters above 0x10000.
Date: 2004-12-03 00:48:17
Message-ID: 200412030048.iB30mHj28446@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> > Fix for Unicode characters above 0x10000.
>
> I really have to object to this going in on the day before RC1, as well.
> (1) There is no way on God's green earth that this isn't a new feature.
> (2) It is mucking with fairly central code.
> (3) AFAIK it hasn't been reviewed by anybody who's familiar with the
> multibyte code.
> (4) How do you know that wider-than-16-bit characters won't break stuff
> elsewhere?

I don't know the answers to any of these questions. I don't even
understand the purpose of the patch. However, no one object to it nor
did they say anything when it went into the queue, so it was applied.

If you are registering concerns, I will remove it. I was unclear about
the patch as well but assumed Unicode-folks were OK with it.

Should it be backed out and saved for 8.1?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Neil Conway 2004-12-03 01:15:16 Re: pgsql: Fix for Unicode characters above 0x10000.
Previous Message Tom Lane 2004-12-03 00:40:30 Re: pgsql: Fix for Unicode characters above 0x10000.