Re: Charset WIN1252

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Roland Volkmann <roland(dot)volkmann(at)gmx(dot)de>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Charset WIN1252
Date: 2004-11-30 16:38:53
Message-ID: 20041130163853.GA7979@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Tue, Nov 30, 2004 at 02:05:31AM +0100, Roland Volkmann wrote:

> this is the first time, I use CVS (TortoisCVS), so I hope the result is
> what you were missing:

You have to include the new files separately. And please send context
diffs, not unified diffs.

Also there's a typo here:

> Index: src/backend/utils/mb/encnames.c
> ===================================================================
> RCS file:
> Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/encnames.c,v
> retrieving revision 1.1
> diff -u -r1.1 encnames.c
> --- src/backend/utils/mb/encnames.c 30 Nov 2004 00:51:56 -0000 1.1
> +++ src/backend/utils/mb/encnames.c 31 Oct 2004 19:09:16 -0000
> @@ -342,6 +348,9 @@
> },
> {
> "WIN1250", PG_WIN1250
> + },
> + {
> + "WIN1250", PG_WIN1252
> },
> {
> "SJIS", PG_SJIS

--
Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
"The important things in the world are problems with society that we don't
understand at all. The machines will become more complicated but they won't
be more complicated than the societies that run them." (Freeman Dyson)

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-11-30 17:57:58 Re: multiline CSV fields
Previous Message Greg Stark 2004-11-30 16:09:15 Re: multiline CSV fields