Re: Faster install-sh in C

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Faster install-sh in C
Date: 2004-11-29 03:43:39
Message-ID: 200411290343.iAT3hdu24467@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


This has been saved for the 8.1 release:

http:/momjian.postgresql.org/cgi-bin/pgpatches2

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Patchers,
>
> I wrote an "install" program in C. It's supposed to replace the
> config/install-sh script, limited to the functionality we need, i.e.
> what is in Makefiles in the Pg main source tree. The main objective of
> this exercise is to reduce "make install" execution time; a part of that
> is being able to install multiple files with one command.
>
> Portability testing right now is limited to my machine, which is Linux
> with glibc 2.3.2 (Debian Sid).
>
> With this in place, "make install" in src/include takes 17 seconds on
> this machine, where the script version takes more than a minute. I
> think this is a useful improvement.
>
>
> Right now I'm missing a Makefile rule for it. It needs the pg_progname
> symbol from src/port, and the includes from $(srcdir)/src/include and
> $(builddir)/src/include. From the config directory, this works:
>
> $(CC) $(CFLAGS) -I$(top_srcdir)/src/include -I$(top_builddir)/src/include ../src/port/path.o ../src/port/exec.o $< -o $@
>
> Also, I don't know how to force it to build before executing "install",
> short of putting it as a dependency in every makefile (which sounds
> silly to me).
>
> I attach the source code, and a src/include/Makefile modification to
> use the multi-file install feature.
>
> --
> Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
> "Hay quien adquiere la mala costumbre de ser infeliz" (M. A. Evans)

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-11-29 03:58:43 Re: multiline CSV fields
Previous Message Neil Conway 2004-11-29 03:33:55 Re: BUG #1329: Bug in IF-ELSEIF-ELSE construct