Re: [HACKERS] Possible make_oidjoins_check Security Issue

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Possible make_oidjoins_check Security Issue
Date: 2004-11-04 02:05:08
Message-ID: 200411040205.iA4258u07548@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Gavin Sherry wrote:
> On Wed, 3 Nov 2004, Bruce Momjian wrote:
>
> > Tom Lane wrote:
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > >> I think Tom's fix adequately addresses the security concerns. Exactly
> > > >> what is wrong with writing to the current working directory?
> > >
> > > > Because it could be run from a directory where others have write
> > > > permission.
> > >
> > > In which case, they could also change the findoidjoins script itself.
> > > I think your fix is *less* secure than what you replaced.
> > >
> > > However, I've already wasted more than enough time on this issue...
> > > I'm done arguing about it.
> >
> > As far as I know, my method is the only secure method. If I am wrong I
> > would like to know.
>
> I think the problem can really be solved by just removing it from the
> distribution. However, one thing I noticed with Bruce's script is that it
> does not respect $TMPDIR -- which security conscious admins may be
> setting. Solution would be to set TMP=${TMPDIR:-/tmp} before defining the
> path to the temporary sub directory.

OK, TMPDIR honored. Thanks.

I am fine with removing it but if we don't I would like to have it
secure, mostly from a public relations perspective.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2004-11-04 02:33:35 Re: pg_autovacuum is nice ... but ...
Previous Message Tom Lane 2004-11-04 01:53:43 Re: pg_autovacuum is nice ... but ...

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-11-04 03:13:15 Re: Edit query buffer
Previous Message Tom Lane 2004-11-04 01:40:01 Re: [HACKERS] Possible make_oidjoins_check Security Issue