| From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix failure to think clearly about encoding conversion errors in |
| Date: | 2004-10-29 19:18:25 |
| Message-ID: | 20041029191825.487C03A3B48@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Fix failure to think clearly about encoding conversion errors in COPY.
We can't regurgitate the unconverted string as I first thought, because
the elog.c mechanisms will assume the error message data is in the server
encoding and attempt a reverse conversion. Eventually it might be worth
providing a short-circuit path to support this, but for now the simplest
solution is to abandon trying to report back the line contents after a
conversion failure. Per bug report from Sil Lee, 27-Oct-2004.
Modified Files:
--------------
pgsql/src/backend/commands:
copy.c (r1.232 -> r1.233)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c.diff?r1=1.232&r2=1.233)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-10-29 19:30:04 | pgsql: No need to set errorMessage length --- already set in goto |
| Previous Message | Bruce Momjian | 2004-10-29 17:53:14 | pgsql: Set errorMessage length in PQrequestCancel() in all places. |