Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: olly(at)lfix(dot)co(dot)uk
Cc: Ian Barwick <barwick(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK
Date: 2004-10-27 18:00:25
Message-ID: 200410271800.i9RI0Po28721@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Oliver Elphick wrote:
> On Tue, 2004-10-26 at 21:42 -0400, Bruce Momjian wrote:
> > > test=> begin;
> > > BEGIN
> > > test=> commit;
> > > COMMIT
> > > test=> commit;
> > > WARNING: there is no transaction in progress
> > > ROLLBACK
> > >
> > > Is there any reason ROLLBACK and not COMMIT is echoed here?
> >
> > Because the transaction was not committed, but rather rolled back.
>
> It's still a misleading message; in those circumstances, how about
> returning "NO ACTION" instead?

Uh, it took a lot of discussion to agree on ROLLBACK. It would take
even more discussion to add a new tag return value.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Reini Urban 2004-10-27 18:17:28 Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path
Previous Message Magnus Hagander 2004-10-27 16:52:56 Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path