Need for DLLINIT in Makefile.shlib

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Cc: PostgreSQL Cygwin mailing list <pgsql-cygwin(at)postgreSQL(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgreSQL(dot)org>
Subject: Need for DLLINIT in Makefile.shlib
Date: 2004-10-11 22:22:57
Message-ID: 200410112222.i9BMMvN01175@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers pgsql-hackers-win32

I am curious why Cygwin needs DLLINIT in Makefile.shlib, and Win32
doesn't:

# Cygwin case
$(shlib) lib$(NAME).a: $(OBJS) $(DLLINIT)
$(DLLTOOL) --export-all $(DLLTOOL_DEFFLAGS) --output-def $(NAME).def $(OBJS)
$(DLLWRAP) -o $(shlib) --dllname $(shlib) $(DLLWRAP_FLAGS) --def $(NAME).def $(OBJS) $(DLLINIT) $(SHLIB_LINK)
$(DLLTOOL) --dllname $(shlib) $(DLLTOOL_LIBFLAGS) --def $(NAME).def --output-lib lib$(NAME).a

$(DLLINIT): $(DLLINIT:%.o=%.c)
$(MAKE) -C $(@D) $(@F)

endif # PORTNAME == cygwin

else # PORTNAME == win32

# win32 case
$(shlib) lib$(NAME).a: $(OBJS)
$(DLLTOOL) --export-all $(DLLTOOL_DEFFLAGS) --output-def $(NAME).def $(OBJS)
$(DLLWRAP) -o $(shlib) --dllname $(shlib) $(DLLWRAP_FLAGS) --def $(NAME).def $(OBJS) $(SHLIB_LINK)
$(DLLTOOL) --dllname $(shlib) $(DLLTOOL_LIBFLAGS) --def $(NAME).def --output-lib lib$(NAME).a

endif # PORTNAME == win32

The only difference I see is that Cygwin uses $(DLLINIT) while Win32 does
not. Is that correct? Why?

Both set DLLINIT in their makefiles:

DLLINIT = $(top_builddir)/src/utils/dllinit.o

Could they be merged into a single snipped of code?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Bruce Momjian 2004-10-11 22:49:38 Re: [HACKERS] open item: tablespace handing in pg_dump/pg_restore
Previous Message Leeuw van der, Tim 2004-10-11 07:26:02 Re: initdb failed

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-10-11 22:49:38 Re: [HACKERS] open item: tablespace handing in pg_dump/pg_restore
Previous Message Bin Liu 2004-10-11 22:13:43 Question about Parser()

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-10-11 22:49:38 Re: [HACKERS] open item: tablespace handing in pg_dump/pg_restore
Previous Message Magnus Hagander 2004-10-11 07:58:56 Re: build error in initdb on win32