Re: [PATCHES] Win32 Version numbering patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Win32 Version numbering patch
Date: 2004-10-09 04:04:29
Message-ID: 200410090404.i9944TE02382@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > I was hoping this would be in for beta 3, but alas - can someone
> > *please* commit the win32 version patch at:
> > http://candle.pha.pa.us/mhonarc/patches/msg00000.html
>
> Personally I was holding off in hopes of seeing a cleaner solution.
> A patch that requires every executable-building Makefile to have a
> platform-specific wart isn't going to be very maintainable. You
> already missed pg_config, plus whichever of the contrib modules build
> executables...

I have added Win32 version information for pg_config. I assume anyone
adding a new client binary will copy an existing one so I am hopeful the
win32 version strings will be maintained.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-10-09 04:14:48 Re: [BUGS] BUG #1270: stack overflow in thread in fe_getauthname
Previous Message Bruce Momjian 2004-10-09 03:24:47 Re: patch for temporary view from TODO list

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-10-09 04:10:39 Re: cast pid_t to int when using *printf
Previous Message Bruce Momjian 2004-10-09 03:24:47 Re: patch for temporary view from TODO list