Re: SSL on win32

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Subject: Re: SSL on win32
Date: 2004-10-06 09:34:28
Message-ID: 200410060934.i969YS026974@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied. Thanks.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Hello!
>
> Here is a patch to fix win32 ssl builds. Summary of changes:
>
> * Links with -leay32 and -lssleay32 instead of crypto and ssl. On win32,
> "crypto and ssl" is only used for static linking.
>
> * Initializes SSL in the backend and not just in the postmaster. We
> cannot pass the SSL context from the postmaster through the parameter
> file, because it contains function pointers.
>
> * Split one error check in be-secure.c. Previously we could not tell
> which of three calls actually failed. The previous code also returned
> incorrect error messages if SSL_accept() failed - that function needs to
> use SSL_get_error() on the return value, can't just use the error queue.
>
> * Since the win32 implementation uses non-blocking sockets "behind the
> scenes" in order to deliver signals correctly, implements a version of
> SSL_accept() that can handle this. Also, add a wait function in case
> SSL_read or SSL_write() needs more data.
>
>
> I'd appreciate it if one of the win32 guys can confirm that this patch
> fixes the build for them as well.
>
>
> //Magnus

Content-Description: win32_ssl.patch

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Luiz K. Matsumura 2004-10-06 12:51:20 Re: pg_dumpall bug in PG 8.0b3 Win32 port
Previous Message Bruce Momjian 2004-10-06 09:20:14 Re: plpython win32