| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Bruce Momjian <momjian(at)svr1(dot)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql-server: Comment out unused variable. |
| Date: | 2004-10-05 02:02:37 |
| Message-ID: | 200410050202.i9522bM02538@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Neil Conway wrote:
> On Tue, 2004-10-05 at 01:09, Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Comment out unused variable.
>
> If it is unused, it ought to be removed IMHO. Merely commenting out
> unused code leads to bloat over time.
It was part of the original NetBSD code so I usually don't remove that
stuff so the code remains a similar as possible.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2004-10-05 10:48:38 | pgsql-server: '::' is no longer interpreted as a variable in a prepare |
| Previous Message | Neil Conway | 2004-10-05 00:14:47 | pgsql-server: Pickup fix from upstream OpenBSD sources: mark a read-only |