Re: xact.c state machine redesign

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: xact.c state machine redesign
Date: 2004-09-15 22:33:26
Message-ID: 20040915223326.GA7813@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 15, 2004 at 01:34:01PM -0400, Tom Lane wrote:
> After looking over the state machine in xact.c, I'm thinking of removing
> the TBLOCK_SUBENDABORT_ALL and TBLOCK_SUBENDABORT_RELEASE states in
> favor of having the ROLLBACK command mark the whole transaction state
> stack similarly to what is now done for COMMIT.

FYI, this idea works for me.

> This isn't any fewer states than we have now, but the states seem much
> more clearly organized to me --- in particular, other than the RESTART
> states there's full symmetry between outer-level and subtransaction
> states.

Excellent. This was my initial idea, but I messed up in the transition
to savepoints.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Postgres is bloatware by design: it was built to house
PhD theses." (Joey Hellerstein, SIGMOD annual conference 2002)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2004-09-15 22:52:09 PostgreSQL Core Committee Welcomes New Member
Previous Message Mark Wong 2004-09-15 22:16:13 Re: some PITR performance data with DBT-2