| From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql-server: On further consideration, there's another problem here: |
| Date: | 2004-09-05 03:42:15 |
| Message-ID: | 20040905034215.B82EB5E40BA@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
On further consideration, there's another problem here: the existing
elog() emulation code always calls errstart with ERROR error level.
This means that a recursive error call triggered by elog would do
MemoryContextReset(ErrorContext), whether or not this was actually
appropriate. I'm surprised we haven't seen this in the field...
Modified Files:
--------------
pgsql-server/src/backend/utils/error:
elog.c (r1.149 -> r1.150)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/error/elog.c.diff?r1=1.149&r2=1.150)
pgsql-server/src/include/utils:
elog.h (r1.75 -> r1.76)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/utils/elog.h.diff?r1=1.75&r2=1.76)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-09-05 23:01:26 | pgsql-server: Simplify IsXactIsoLevelSerializable test. |
| Previous Message | Tom Lane | 2004-09-05 02:01:42 | pgsql-server: Tweak elog.c's logic for promoting errors into more severe |