| From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql-server: Code review for recent changes in guc-file.l. |
| Date: | 2004-08-31 22:43:58 |
| Message-ID: | 20040831224358.ED8B05E471B@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Code review for recent changes in guc-file.l. Avoid multiple frees,
use of already-freed strings, other silliness. Also fix reporting of
config file syntax errors so that it actually works reasonably well
(eg, points at the correct line). Use palloc instead of malloc for
temporary storage to reduce code clutter.
Modified Files:
--------------
pgsql-server/src/backend/utils/misc:
guc-file.l (r1.24 -> r1.25)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/misc/guc-file.l.diff?r1=1.24&r2=1.25)
guc.c (r1.237 -> r1.238)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/misc/guc.c.diff?r1=1.237&r2=1.238)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-08-31 23:16:36 | pgsql-server: Repair 'expected both swapped tables to have TOAST tables' |
| Previous Message | User Dpage | 2004-08-31 22:40:57 | pginstaller - pginst: Pull /contrib stuff from main installation |