From: | momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql-server: >>> I understand your disliking of non-posix stuff. |
Date: | 2004-08-29 00:38:04 |
Message-ID: | 20040829003804.2D2575E46E7@svr1.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
>>> I understand your disliking of non-posix stuff. OTOH,
>>GetLastError will
>>> give much more details than errno.
>>
>>How much more, really? That mapping table gave me the impression that
>>the win32 error codes aren't all that much more detailed than errno...
>
>The mapping table is not complete. My winerror.h from the SDK
>lists 2209
>error codes, whereas errno.h lists 42...
>
>I still don't think we'll get that much more stuff. Right now,
>the Win32
>code paths that actually use the more advanced functions already write
>out the error number in case something happens. We can keep doing that
>for the other paths (ereport the error *number* when the mapping does
>not have a match). The map to errno will catch almost all cases, I
>think. And in the corner cases we can do with just the number, and use
>"net helpmsg" to get the actual message when checking...
Here's an attempt on this. new file goes in backend/port/win32.
Magnus Hagander
Modified Files:
--------------
pgsql-server/src/backend/port/win32:
Makefile (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/port/win32/Makefile.diff?r1=1.5&r2=1.6)
shmem.c (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/port/win32/shmem.c.diff?r1=1.5&r2=1.6)
pgsql-server/src/backend/postmaster:
syslogger.c (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/postmaster/syslogger.c.diff?r1=1.5&r2=1.6)
pgsql-server/src/include/port:
win32.h (r1.27 -> r1.28)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/port/win32.h.diff?r1=1.27&r2=1.28)
Added Files:
-----------
pgsql-server/src/backend/port/win32:
error.c (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/port/win32/error.c?rev=1.1&content-type=text/x-cvsweb-markup)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-08-29 01:44:02 | pgsql-server: Add comment on palloc use and DLLIMPORT> |
Previous Message | User Dpage | 2004-08-29 00:04:05 | pginstaller - pginst: Added basic framework for contrib modules, and |