Re: postgresql-7.4.5-1 ready for review

From: Jason Tishler <jason(at)tishler(dot)net>
To: cygwin-apps(at)cygwin(dot)com
Cc: pgsql-cygwin(at)postgresql(dot)org
Subject: Re: postgresql-7.4.5-1 ready for review
Date: 2004-08-27 12:00:36
Message-ID: 20040827120036.GA87688@tishler.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-patches

Reini,

On Thu, Aug 26, 2004 at 06:59:24PM +0200, Reini Urban wrote:
> Jason Tishler schrieb:
> >On Wed, Aug 25, 2004 at 08:09:26PM +0200, Reini Urban wrote:
> >>ok, postgresql-7.4.5-1 is ready.
> >
> >Thanks, but I'm going to upload a postgresql-7.4.5-1 shortly. Let's
> >transition maintainership in the 8.0 time frame.
>
> Super. So I can check tcl also.

Please do. Building with Tcl is only the first step, I never got PL/Tcl
to work.

> Please also check my version of the cygwin README. I added a "Whats
> new" section.

Will do.

> >AFAICT, the above change is not necessary:
> >
> > checking for shmget in -lcygipc... no
> > ...
> > checking sys/ipc.h usability... yes
> > checking sys/ipc.h presence... yes
> > checking for sys/ipc.h... yes
>
> The problem is, that I still have cygipc installed, so it will find
> it, even if cygserver is running. Others maybe also. Call it
> defensive programming.

If you are going to maintain Cygwin PostgreSQL, then I highly recommend
uninstalling the deprecated cygipc package.

> Anyway my postgresql-7.4.5-1 cygipc configure.in patch is pending, and
> will be useful for the 8 series also.

AFAICT, your configure.in patch has been rejected. Sorry, but I have to
agree with Peter.

Jason

--
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6

In response to

Browse pgsql-cygwin by date

  From Date Subject
Next Message Reini Urban 2004-08-27 15:20:21 Re: Any working PL./Perl instance of - Postgres 7.4.5-1,perl-5.8.5
Previous Message CSN 2004-08-27 06:13:56 Re: Changing/Specifying Data Dir to postmaster Service

Browse pgsql-patches by date

  From Date Subject
Next Message Ed L. 2004-08-27 17:50:16 log_filename_prefix --> log_filename + strftime()
Previous Message pgsql 2004-08-26 22:17:34 Contrib Shared varaibles