Re: 8.0.0 beta 1, contrib/dbsize, GetDatabasePath wrong

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: mdaniel(at)scdi(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: 8.0.0 beta 1, contrib/dbsize, GetDatabasePath wrong
Date: 2004-08-17 20:22:35
Message-ID: 200408172022.i7HKMZP25523@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


This has been corrected in current CVS.

---------------------------------------------------------------------------

Matthew L Daniel wrote:
> dbsize.c was not updated to use the new tablespace-aware function.
>
> I am not well versed enough with the new function to know if "GLOBAL..."
> was the correct default for what dbsize is trying to do. I just thought
> you guys might want to know.
>
> Thanks for the WORLD'S GREATEST OpenSource DB!
> -- /v\atthew
>
> --- postgresql-8.0.0beta1/contrib/dbsize/dbsize.c~ 2004-02-23 18:03:10.000000000 -0500
> +++ postgresql-8.0.0beta1/contrib/dbsize/dbsize.c 2004-08-11 17:08:44.000000000 -0400
> @@ -7,6 +7,7 @@
> #include "access/heapam.h"
> #include "catalog/catalog.h"
> #include "catalog/namespace.h"
> +#include "catalog/pg_tablespace.h"
> #include "commands/dbcommands.h"
> #include "fmgr.h"
> #include "storage/fd.h"
> @@ -55,7 +56,7 @@
> (errcode(ERRCODE_UNDEFINED_DATABASE),
> errmsg("database \"%s\" does not exist", NameStr(*dbname))));
>
> - dbpath = GetDatabasePath(dbid);
> + dbpath = GetDatabasePath(dbid, GLOBALTABLESPACE_OID);
>
> dirdesc = AllocateDir(dbpath);
> if (!dirdesc)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Ken Egervari 2004-08-17 20:47:19 I/O Bug
Previous Message Tom Lane 2004-08-17 20:05:24 Re: Garbage characters for \d table?