Re: [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [Fwd: Re: [pgsql-hackers-win32] Import from Linux to
Date: 2004-08-14 21:44:35
Message-ID: 200408142144.i7ELiZO28037@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>
> >"Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
> >
> >
> >>No, I think 7.4 should do. 7.3 users will still have the dos2unix workaround
> >>available. Are you going to do the 7.4 patch, or do you need me to? I
> >>normally only keep a HEAD tree checked out. A quick look at the cvsweb diffs
> >>suggests the patch should apply cleanly but with different line offsets.
> >>
> >>
> >
> >If you're sure the code in that routine hasn't changed since 7.4, then I
> >can just apply the patch to that branch.
> >
> >
> >
> >
>
> It has - the prompt changes in version 1.37. But I don't think that
> conflict with this patch. I'll have a look this morning.

One issue is that pre-8.0, psql files were opened in Win32 text mode, so
we wouldn't have seen this bug on Win32, but we would on Linux.
Because we open them on Win32 now in binary mode so we see control-Z it
will show up on Win32 too.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2004-08-14 22:09:08 Re: [Fwd: Re: [pgsql-hackers-win32] Import from Linux to
Previous Message Andrew Dunstan 2004-08-14 21:07:58 Re: Calling PL functions with named parameters

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-08-14 22:09:08 Re: [Fwd: Re: [pgsql-hackers-win32] Import from Linux to
Previous Message Bruce Momjian 2004-08-14 21:13:27 Re: to_timestamp overloaded to convert from Unix epoch