Re: logfile subprocess and Fancy File Functions

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: logfile subprocess and Fancy File Functions
Date: 2004-07-24 22:55:58
Message-ID: 200407242255.i6OMtwJ26035@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, let's go with something that is purely log file stuff.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Agreed it should be relative to the log directory, which may or not be
> > under PGDATA, and don't let them go up above it. Is there any downside
> > to allowing absolute reads as well because COPY can already read
> > absolute files.
>
> Perhaps not from a security point of view, but I think it would be
> rather bizarre for a general-purpose pg_read_file() function to default
> to reading from the log directory. From the point of view of having
> a consistent API, it'd be better to call the functions something like
> pg_read_logdirectory() and pg_read_logfile() and restrict them to the
> log directory. If we later decide we want to add a general
> pg_read_file() operation, we won't have to contort its operation to
> preserve compatibility with the log-fetching case.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-07-24 23:00:59 Re: logfile subprocess and Fancy File Functions
Previous Message Bruce Momjian 2004-07-24 22:55:33 Re: [HACKERS] Function to kill backend