| From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql-server: Adjust TAS assembly as per recent discussions: use |
| Date: | 2004-06-19 23:02:33 |
| Message-ID: | 20040619230233.D454CD1B188@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Adjust TAS assembly as per recent discussions: use "+m"(*lock) everywhere
to reference the spinlock variable, and specify "memory" as a clobber
operand to be sure gcc does not try to keep shared-memory values in
registers across a spinlock acquisition. Also tighten the S/390 asm
sequence, which was apparently written with only minimal study of the
gcc asm documentation. I have personally tested i386, ia64, ppc, hppa,
and s390 variants --- there is some small chance that I broke the others,
but I doubt it.
Modified Files:
--------------
pgsql-server/src/include/storage:
s_lock.h (r1.125 -> r1.126)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/storage/s_lock.h.diff?r1=1.125&r2=1.126)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-06-20 01:32:51 | pgsql-server: Add pgevent, with docs explaining out to install it on |
| Previous Message | Tom Lane | 2004-06-19 20:31:59 | pgsql-server: Looks like s_lock_test needs <time.h> on some platforms. |