Re: Tablespace patch review

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Tablespace patch review
Date: 2004-06-18 23:31:31
Message-ID: 200406182331.i5INVVv16564@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > On Fri, 18 Jun 2004, Bruce Momjian wrote:
> >> * Allow reporting of which objects are in which tablespaces

This would have to be an external tool that connects to each database.

>
> > Do we need an information_schema.tablespaces view as well as an update to
> > information_schema.{tables|indexes|...} ?
>
> That would depend on your theology about whether implementation-specific
> additions to information_schema are a good idea or not. I'd lean
> against doing this myself. ISTM the entire point of information_schema
> is to be standard, and additions are, well, not. Worse, they might
> conflict with future extensions to the standard.
>
> I don't actually see a way *inside the database* to implement Bruce's
> TODO item; there's no way for a backend to look at the catalogs of other
> databases. We could look to see which databases had nonempty
> subdirectories of a tablespace, and report those databases by name, but
> explaining exactly what's inside those subdirectories is a lot harder.

The best we could do here is to just report the database name and the
relfilenode.

>
> It might be better to think about supporting this need with oid2name
> or some similar client-level tool. It's easy to see how oid2name
> might be extended to produce an output like
>
> Tablespace t1
> Database d1
> Table x
> Table y
> Database d2
> etc etc

Yep, that's what I was thinking --- an external tool.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Pflug 2004-06-18 23:49:37 Re: Tablespace patch review
Previous Message Tom Lane 2004-06-18 23:21:45 Re: Cannot initdb in cvs tip

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2004-06-18 23:49:37 Re: Tablespace patch review
Previous Message Oliver Jowett 2004-06-18 23:30:49 Re: [PATCHES] Nested transactions