Re: [HACKERS] New pg_ctl has retrogressed in error messages

Tom Lane wrote:
> 7.4, on not finding a postmaster:
>
> [tgl(at)rh1 pgsql]$ pg_ctl stop
> /home/tgl/version74/bin/pg_ctl: line 274: kill: (15273) - No such process
> waiting for postmaster to shut down................................................................ failed
> pg_ctl: postmaster does not shut down
>
> CVS tip, same scenario:
>
> [tgl(at)rh1 pgsql]$ pg_ctl stop
> stop signal failed
>
> Not waiting for the results of a failed kill() is good, but the error
> message is exceedingly unhelpful. It should mention the PID it tried to
> kill and give the errno string. Perhaps
>
> failed to signal postmaster process 15273: No such process

OK, new output is:

$ aspg pg_ctl stop
stop signal failed (PID: 3603): No such process

I also changed all the pid variables to use pid_t.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073