Re: linked list rewrite

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: linked list rewrite
Date: 2004-04-28 04:12:21
Message-ID: 200404280412.i3S4CLV19040@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > Most of your suggestions are agreeable; a few minor quibbles follow.
>
> >> lfirstcell new function to get first cell, or NULL if none
> > [...]
> >> llastnode llastcell
>
> > What do you think of list_head() and list_tail() instead?
>
> No strong objection, though I thought it was a good idea to include
> "cell" in the function names to suggest that what you are getting back
> is just a cell and not a List. Anyone else have a preference?

I never liked "cell" myself. It is too vague to me. But I see your
point that list_head you would think returns the head of the list, not
the first element in the list. Maybe list_first and list_last?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message David Garamond 2004-04-28 04:48:49 Re: shadowing (like IB/Firebird)
Previous Message Bruce Momjian 2004-04-28 04:01:03 Re: WAL details

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Payne 2004-04-28 04:24:22 Re: What can we learn from MySQL?
Previous Message Tom Lane 2004-04-28 04:08:48 Re: btbulkdelete