Re: installdir patch for win32

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, "''pgsql-patches(at)postgresql(dot)org' '" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: installdir patch for win32
Date: 2004-03-26 02:09:17
Message-ID: 20040326020917.GD5088@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, Mar 25, 2004 at 07:57:19PM -0500, Tom Lane wrote:

> I'm not expecting to see zero ifdefs --- certainly not in the port
> modules ;-). But Bruce's search, further up in the thread, showed that
> #ifdef WIN32's are sneaking into a lot of modules that probably
> shouldn't have any platform dependencies.

Don't forget about the EXEC_BACKEND businness ... is there any chance
those could refactored somehow?

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Amanece. (Ignacio Reyes)
El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen"

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-03-26 02:45:32 Re: installdir patch for win32
Previous Message Claudio Natoli 2004-03-26 01:29:14 Re: APC/socket fix (final?)