Re: Doc for ltrim and rtrim

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Dennis Bjorklund <db(at)zigo(dot)dhs(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Doc for ltrim and rtrim
Date: 2004-03-04 23:36:49
Message-ID: 200403042336.i24Nans13630@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway wrote:
> Bruce Momjian wrote:
> > No problem. See the developers page for 5-minute build so you can check
> > your commit.
>
> I think it's best if people always check that they don't break the
> docs before committing changes. "make check" should be sufficient, and
> that is much faster than building the docs completely.

But that assumes he already has SGML tools available, which isn't true
for everyone.

Also, I just tried it here:

(4) cd sgml/
(4) gmake check
LC_ALL=C /usr/bin/perl
/usr/local/share/sgml/docbook-dsssl/bin/collateindex.pl -f -g -o
bookindex.sgml -N
{ \
echo "<!entity version \"7.5devel\">"; \
echo "<!entity majorversion \"`expr 7.5devel :
'\([0-9][0-9]*\.[0-9][0-9]*\)'`\">"; \
} >version.sgml
/usr/bin/perl ./mk_feature_tables.pl YES
../../../src/backend/catalog/sql_feature_packages.txt
../../../src/backend/catalog/sql_features.txt > features-supported.sgml
/usr/bin/perl ./mk_feature_tables.pl NO
../../../src/backend/catalog/sql_feature_packages.txt
../../../src/backend/catalog/sql_features.txt >
features-unsupported.sgml
onsgmls -wall -wno-unused-param -wno-empty -D . -s postgres.sgml

Wow, that was a fast check. I added a syntax error and it did indeed
find it, so it must work well as a checker.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-03-05 00:05:05 Re: Fix for log_executor_stats
Previous Message Bruce Momjian 2004-03-04 23:31:54 Re: "ALSO" keyword to "CREATE RULE" patch