Re: [PATCHES] update i386 spinlock for hyperthreading

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jan Wieck <JanWieck(at)Yahoo(dot)com>, Manfred Spraul <manfred(at)colorfullife(dot)com>, pgsql-hackers(at)postgresql(dot)org, markw(at)osdl(dot)org
Subject: Re: [PATCHES] update i386 spinlock for hyperthreading
Date: 2003-12-30 14:56:04
Message-ID: 200312301456.hBUEu4n13503@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers pgsql-patches

Tom Lane wrote:
> Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> >> That's irrelevant to the problem, though. Unless the ARC code uses data
> >> structures that are more amenable to localized locking than the old
> >> global buffer freelist. (Jan?)
>
> > the strategy itself does no locking at all. Like the old LRU code it
> > simply assumes that the buffer manager holds the lock during calls.
>
> Okay, I suspected as much but wasn't sure.
>
> Manfred's numbers definitely say that we need to find a way to break
> down the BufMgrLock into multiple finer-grain locks. We already have
> all those per-buffer LWLocks, but I don't see how to apply those to
> the problem of managing the global lookup and replacement datastructures.
>
> Anyone see an attack path here?

Should we have one lock per hash bucket rather than one for the entire
hash?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Jeff Eckermann 2003-12-30 14:58:25 Re: [pgsql-advocacy] Is my MySQL Gaining ?
Previous Message Carmen Gloria Sepulveda Dedes 2003-12-30 14:39:29 Problem with ecpg

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Eckermann 2003-12-30 14:58:25 Re: [pgsql-advocacy] Is my MySQL Gaining ?
Previous Message B. van Ouwerkerk 2003-12-30 13:33:22 Re: Is my MySQL Gaining ?

Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Spraul 2003-12-30 15:17:10 Re: [PATCHES] update i386 spinlock for hyperthreading
Previous Message Tom Lane 2003-12-30 05:41:30 Re: [PATCHES] update i386 spinlock for hyperthreading