From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | Manfred Koizar <mkoi-pg(at)aon(dot)at>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: introduce "default_use_oids" |
Date: | 2003-12-01 04:57:22 |
Message-ID: | 200312010457.hB14vM717423@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
> On Fri, 2003-10-10 at 05:56, Manfred Koizar wrote:
> > On Tue, 30 Sep 2003 20:00:22 -0400, Neil Conway <neilc(at)samurai(dot)com>
> > wrote:
> > >This patch adds a new GUC var, "default_use_oids"
> >
> > Shouldn't it be honoured by CREATE TABLE AS SELECT ... ?
>
> Good catch. I've attached an updated patch. I also included a few
> improvements to the docs.
>
> I think it would be a good idea to extend CREATE TABLE AS to allow WITH
> OIDS and WITHOUT OIDS to be specified, so that it provides a better
> option for people who need OIDs in their CREATE TABLE AS-generated
> tables than manually setting the default_use_oids GUC var (CREATE TABLE
> AS should also accept ON COMMIT ..., for that matter). But implementing
> this will require changing the internal representation of CREATE TABLE
> AS to be something more than just a wrapper over SelectStmt, I believe.
> I haven't made this change in the attached patch, but I'll probably do
> it before 7.5 is released. Any comments?
>
> -Neil
>
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-12-01 04:59:19 | Re: [Fwd: Make psql use all pretty print options] |
Previous Message | Tom Lane | 2003-12-01 04:57:06 | Re: [HACKERS] Index creation takes for ever |