Re: pg_ctl reports succes when start fails

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_ctl reports succes when start fails
Date: 2003-10-23 16:44:56
Message-ID: 200310231644.h9NGiuP25950@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32

Andrew Dunstan wrote:
> Tom Lane wrote:
>
> >Tommi Maekitalo <t(dot)maekitalo(at)epgmbh(dot)de> writes:
> >
> >
> >>I installed 7.4beta5, created a data-dir and tried to start postgresql with
> >>pg_ctl without initdb. As expected, this will fail. But pg_ctl tells me
> >>"postmaster successfully started", after a fatal error, which looks very
> >>confusing. When I use -l for specifying a logfile, I don't even see the
> >>error, but only the success-message.
> >>
> >>
> >
> >If you don't use -w, then pg_ctl doesn't wait around to see whether the
> >postmaster started or not. It'd probably be a good idea for it to issue
> >a less positive message in this case, maybe only "postmaster launched".
> >
> >I also wonder why -w isn't the default.
> >
> >
> >
> It is for stop but not for start/restart, which does seem a bit odd.
>
> On a slightly related note, I see that this is still a shell script, as
> are initlocation, ipcclean and pg_config. I assume these will have to be
> rewritten in C for the Win32 port?

OK, I updated the Win32 web page to mention we need a C version of
pg_ctl. I don't think we will need pg_config once we have initdb in C,
and I don't think it is worth doing initlocation because we need
tablespaces.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-10-23 16:51:10 Re: pg_ctl reports succes when start fails
Previous Message Bruce Momjian 2003-10-23 16:40:43 Re: Last beta ... we hope?

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2003-10-23 16:51:10 Re: pg_ctl reports succes when start fails
Previous Message Christopher Kings-Lynne 2003-10-23 15:28:04 Re: pg_ctl reports succes when start fails