Re: _GNU_SOURCE

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, next question is whether we should use _GNU_SOURCE only for plperl
> > compile, rather than everything. _GNU_SOURCE seems to do lots of stuff
> > that I am uncertain about.
>
> We've been using it for awhile, and it's not broken anything. Why are
> you so eager to make build changes with potentially wide ramifications
> so late in the beta cycle? I didn't agree with your changes to CFLAGS

I don't know what the ramifications of _GNU_SOURCE are, but we have run
longer without it than with it. Seems safest to have it only where we
need it, in plperl.

> yesterday, either. The risk of breaking things on some platform greatly
> outweighs the potential benefits at this stage.

Well, the compile flags were broken by almost any measure. I don't
want to ship without optimization for 7.4 for all those platforms.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073