Re: [HACKERS] Sun performance - Major discovery!

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Jeff <threshar(at)torgo(dot)978(dot)org>, PostgreSQL Performance <pgsql-performance(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Sun performance - Major discovery!
Date: 2003-10-09 03:19:51
Message-ID: 200310090319.h993JpM10523@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > On Wed, 2003-10-08 at 14:31, Bruce Momjian wrote:
> >> Well, this is really embarassing. I can't imagine why we would not set
> >> at least -O on all platforms.
>
> I believe that autoconf will automatically select -O2 (when CFLAGS isn't
> already set) *if* it's chosen gcc. It won't select anything for vendor
> ccs.
>
> > Can we get these optimizations enabled in time for the next 7.4 beta?
>
> I think it's too late in the beta cycle to add optimization flags except
> for platforms we can get specific success results for. (Solaris is
> probably okay for instance.) The risk of breaking things seems too
> high.

OK, patch attached and applied. It centralizes the optimization
defaults into configure.in, rather than having CFLAGS= in the template
files.

It used -O2 for gcc (generated automatically by autoconf), and -O for
non-gcc, unless the template overrides it.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 11.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthew T. O'Connor 2003-10-09 03:24:31 Re: Autovacuum readme
Previous Message Bruce Momjian 2003-10-09 03:17:38 Re: missing COMMENT ON objects

Browse pgsql-performance by date

  From Date Subject
Next Message Tom Lane 2003-10-09 05:10:54 Re: [HACKERS] Sun performance - Major discovery!
Previous Message Christopher Browne 2003-10-09 02:07:46 Re: Compare rows