Re: pg_dump bug in 7.4

I have added this to the 7.4 open items list:

Fix pg_dump of CREATE TABLE test (col1 BOOLEAN CONSTRAINT test
CHECK (col1))

---------------------------------------------------------------------------

Bruno Wolff III wrote:
> The following is still a problem in current cvs (as of 2 hours ago).
> Normally I wouldn't bug people about this again this soon, but with talk of
> a release candidate next week I wanted to make sure that it wasn't forgotten.
>
> On Sun, Sep 28, 2003 at 20:14:03 -0500,
> Bruno Wolff III <bruno(at)wolff(dot)to> wrote:
> > If you have a check constraint that tests if a boolean column is not
> > false by just using the column name, pg_dump doesn't include parens
> > around the check constraint which causes a syntax error when reloading
> > the database.
> >
> > Using the following to create a table:
> > create table test (col1 boolean constraint test check (col1));
> >
> > pg_dump -c produced the following:
> > --
> > -- PostgreSQL database dump
> > --
> >
> > SET SESSION AUTHORIZATION 'postgres';
> >
> > SET SESSION AUTHORIZATION 'bruno';
> >
> > SET search_path = public, pg_catalog;
> >
> > DROP TABLE public.test;
> > SET SESSION AUTHORIZATION 'postgres';
> >
> > --
> > -- TOC entry 3 (OID 2200)
> > -- Name: public; Type: ACL; Schema: -; Owner: postgres
> > --
> >
> > REVOKE ALL ON SCHEMA public FROM PUBLIC;
> > GRANT ALL ON SCHEMA public TO PUBLIC;
> >
> >
> > SET SESSION AUTHORIZATION 'bruno';
> >
> > --
> > -- TOC entry 4 (OID 605016)
> > -- Name: test; Type: TABLE; Schema: public; Owner: bruno
> > --
> >
> > CREATE TABLE test (
> > col1 boolean,
> > CONSTRAINT test CHECK col1
> > );
> >
> >
> > --
> > -- Data for TOC entry 5 (OID 605016)
> > -- Name: test; Type: TABLE DATA; Schema: public; Owner: bruno
> > --
> >
> > COPY test (col1) FROM stdin;
> > \.
> >
> >
> > SET SESSION AUTHORIZATION 'postgres';
> >
> > --
> > -- TOC entry 2 (OID 2200)
> > -- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: postgres
> > --
> >
> > COMMENT ON SCHEMA public IS 'Standard public schema';
> >
> >
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073