Re: pg_dump no longer honors --no-reconnect

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump no longer honors --no-reconnect
Date: 2003-09-29 15:35:42
Message-ID: 200309291535.h8TFZgY21612@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > but I don't see how we can ignore a --no-reconnect flag --- we should
> > throw an error.
>
> We can ignore it because we don't reconnect. I only took out the flag
> because I noticed it was no longer tested anywhere after I removed the
> \connect code paths. I'm not sure if the old docs mentioned that
> --no-reconnect was irrelevant when using set-session-authorization,
> but that's how the code behaved.
>
> > Also, the 7.3 manual mentions that only the super-user can restore using
> > --use-set-session-authorization. This is now the only way to create
> > dumps. Seems this is a new limitation to pg_dump that we didn't
> > discuss.
>
> No, because a non-superuser can still restore with --no-owner; which is
> actually a step forward over what he could have done with a \connect script.
> (Unless you think that the scenario of a non-superuser who knows
> everyone's password is something pg_dump needs to cater to.)

Oh, OK, thanks. My initial mistake was reading --no-reconnect as
--reconnect; not sure how I did that.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-09-29 15:39:33 Re: 2-phase commit
Previous Message Tom Lane 2003-09-29 15:30:06 Re: pg_dump no longer honors --no-reconnect