Re: pg_dump bug in 7.4

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruno Wolff III <bruno(at)wolff(dot)to>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump bug in 7.4
Date: 2003-09-29 14:02:48
Message-ID: 200309291402.h8TE2m010190@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruno Wolff III wrote:
> On Sun, Sep 28, 2003 at 23:16:48 -0400,
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > Christopher Kings-Lynne wrote:
> > > If you are referring to my patch, Bruce - that does not fix it. Mine
> > > only addresses psql.
> > >
> > > I don't think that pg_dump uses pg_get_constraintdef(). It's probably a
> > > side effect of switching from using consrc to conbin.
> >
> >
> > Oh, yea. If forgot the pretty printing only happens in psql.
> >
> > Can someone generate a reproducable failure?
>
> You should be able to get my example to work pretty easily.
>
> Create a table in a convenient database using the following:
> create table test (col1 boolean constraint test check (col1));
>
> Then pg_dump -c the database. As shown in my example below you
> with have a check constraint that is missing parens which will
> cause a syntax error if you try to reload the dump.

OK, it's a must-fix bug for 7.4. Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-09-29 14:10:17 Re: 2-phase commit
Previous Message Marc G. Fournier 2003-09-29 13:56:42 Re: 2-phase commit