Re: old pgindent change

I have applied the following patch to allow newer BSD indents to work
with pgindent. Thanks.

---------------------------------------------------------------------------

Nigel J. Andrews wrote:
>
> There was a simple change commited in revision 1.47 of pgindent, listed as
> being "More updates for GNU indent".
>
> The questions are: why? and surely I can't be the only one whose hit this
> problem since November 2001?
>
> On a debian (woody or potato, which ever one had a 2.2 series kernal) using
> GNU bash 2.03.0 via /bin/sh (in the pgindent script) I get:
>
>
> which indent = /usr/local/bin/indent
> indent -version = Berkeley indent 5.17
>
> status = 0
> You do not appear to have 'indent' installed on your system.
>
> By adding appropiate echo commands before and after the indent -version line in
> the script, I've attached my slightly modified version for completeness. I can
> never remember the way around the test of $? succeds or fails but the above
> experiment plus a look at the near by tests of $? in pgindent seem to show that
> there is a problem here.
>
> A simple test of 2.05a.0 on a newer system using:
>
> ls
> if [ $? -eq 0 ]; then echo success aaa; fi
> lls
> if [ $? -eq 0 ]; then echo success bbb; fi
>
> shows that the lls (non-existant executable) status fails the test as expected
> while the plain ls status passes.
>
> I'm obviously missing something very significant here or there's a very strange
> oddity that's been there, and specifically placed there, for nearly 2 years.
>
>
> --
> Nigel J. Andrews

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073