Re: [PATCHES] Reorganization of spinlock defines

Marc G. Fournier wrote:
> > > >From what I understand, "not working properly" means slow, not broken, no?
> > > Which means ppl could submit a problem report and it could be fixed for
> > > v7.4.1 ... its not so much 'not working properly' as it is 'not optimal
> > > performance' ...
> >
> > Right, though I am not sure people will know _slow_ configuration vs.
> > PostgreSQL is slow.
>
> No, but definitely something for those discussion performance to add
> to their checklist :)
>
> BTW, post-compile, running system ... how do you check this? Or can you?
>
> For instance, having a checklist, of sorts, that ppl can go through when
> trying to investigate performance issues could include stuff like:
>
> check swap usage (albeit obvious to alot of ppl, not to all)
> check disk usage using iostat
> check spinlocks in use using ... ??

We can add the compiler test that will throw an error if they aren't
using spinlocks, and they have to use a configure flag to enable it.
The only issue there is that this is going to throw up perhaps many
cases we haven't gotten working, and they might dribble out for weeks or
after final, while a clean solution could break more platforms in the
short term, but could catch more in the long term.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073