Re: [PATCHES] WIN32_CONSOLE usage

From: Christoph Dalitz <christoph(dot)dalitz(at)hs-niederrhein(dot)de>
To: Manfred Spraul <manfred(at)colorfullife(dot)com>
Cc: peter_e(at)gmx(dot)net, pgman(at)candle(dot)pha(dot)pa(dot)us, pgsql-patches(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org, pgsql-cygwin(at)postgresql(dot)org
Subject: Re: [PATCHES] WIN32_CONSOLE usage
Date: 2003-09-11 19:13:26
Message-ID: 20030911211326.52fb7bee.christoph.dalitz@hs-niederrhein.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers-win32 pgsql-patches

On Thu, 11 Sep 2003 20:51:24 +0200
Manfred Spraul <manfred(at)colorfullife(dot)com> wrote:
>
> - OemToChar() and CharToOem() convert all console input/output. In the
> long run this might be the better solution, if it works entirely without
> user intervention. I'm not sure if it's possible to get all corner cases
> right.
>
I do not think that it is possible to handle all cases automatically.
Even restricting the conversion to input/output on stdin/stdout will fail in
some circumstances; eg. with the command "psql < script.sql" when the
script has been written with a windows editor (notepad, emacs or whatever).

That's why we introduced the WIN32_CONSOLE parameter, which was admittedly
not such a good idea and should be withdrawn.

Instructing the user how to set up the console so that 8-bit characters work
once and forever is the "rigth way" IMHO. The user will also profit from this
lesson when he uses some other console application, eg. the sqlite SQL-shell.

I will send in the "Win32 console setup instructions" next week.

Christoph

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Manfred Spraul 2003-09-11 20:04:18 Re: [PATCHES] WIN32_CONSOLE usage
Previous Message Christoph Dalitz 2003-09-11 19:04:03 Re: [PATCHES] WIN32_CONSOLE usage

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Manfred Spraul 2003-09-11 20:04:18 Re: [PATCHES] WIN32_CONSOLE usage
Previous Message Christoph Dalitz 2003-09-11 19:04:03 Re: [PATCHES] WIN32_CONSOLE usage

Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Spraul 2003-09-11 20:04:18 Re: [PATCHES] WIN32_CONSOLE usage
Previous Message Christoph Dalitz 2003-09-11 19:04:03 Re: [PATCHES] WIN32_CONSOLE usage