Re: [PATCHES] WIN32_CONSOLE usage

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Christoph Dalitz <christoph(dot)dalitz(at)hs-niederrhein(dot)de>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, manfred(at)colorfullife(dot)com,pgsql-patches(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org,pgsql-cygwin(at)postgresql(dot)org
Subject: Re: [PATCHES] WIN32_CONSOLE usage
Date: 2003-09-11 16:45:22
Message-ID: 200309111645.h8BGjM817244@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-cygwinpgsql-hackers-win32pgsql-patches

Christoph Dalitz wrote:
> > Please send in a patch. Else, someone else is going to try to fix it with
> > less guarantees that it will work afterwards.
> >
> Ok. I can do the following:
>
> a) Write documentation how the win32 console needs to be set up so that
> psql can handle 8-bit characters.
> Where should it be added? The Section "Installation on Windows" in the
> Administrator's Guide seems natural to me.
>
> b) Add code to psql that prints a warning on startup of psql when the
> console codepage differs from the windows codepage, something like
>
> Warning: Console codepage (850) differs from windows codepage (1252)
> 8-bit characters will not work correctly. See PostgreSQL
> documentation "Installation on Windows" for details.
>
> Unfortunately there seems to be no automatic solution to the "console codepage problem",
> because the windows codepage does not work with the default console font.
> Thus the user must tweak his console settings in any case and I think a warning
> is the best to remind the user of this issue.
>
> Please let me know whether this "solution" would be ok. Then I can do it on Monday.

Sounds good.

> @Bruce:
> -------
>
> Could you please already remove the WIN32_CONSOLE and OemToChar/CharToOem stuff
> from psql? Sorry for the inconvenience generated by my ignorance.

OK.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-cygwin by date

  From Date Subject
Next Message Peter Eisentraut 2003-09-11 18:30:53 Re: [PATCHES] WIN32_CONSOLE usage
Previous Message STEWART ABBOTT 2003-09-11 15:05:45 cannot start postgres version 7.3.4

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-11 17:15:31 Re: [HACKERS] New array functions
Previous Message Bruce Momjian 2003-09-11 16:22:43 Re: typo in datetime ref page

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Peter Eisentraut 2003-09-11 18:30:53 Re: [PATCHES] WIN32_CONSOLE usage
Previous Message Christoph Dalitz 2003-09-11 09:17:49 Re: [PATCHES] WIN32_CONSOLE usage