Re: Another small bug (pg_autovacuum)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
Cc: Adam Kavan <akavan(at)cox(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Another small bug (pg_autovacuum)
Date: 2003-09-10 19:57:47
Message-ID: 200309101957.h8AJvlH27895@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


I assume the attached patch is what you want done to fix this. Applied.

It quotes table names for vacuum and analyze, and uppercases the
keywords for clarity.

---------------------------------------------------------------------------

Matthew T. O'Connor wrote:
> Ouch... sorry, my fault. I'll fix this tomorrow (Friday) and submit a
> patch, or if you want to submit a patch that would be fine. All you
> have to do is change the the sql statements to put quotes around the
> relation name.
>
> Thanks for catching this.
>
> Matthew T. O'Connor
>
> On Thu, 2003-09-04 at 18:39, Adam Kavan wrote:
> > Now that I have pg_autovacuum working I've bumped into another small
> > bug. When pg_autovacuum goes to vacuum or analyze one of my tables it runs...
> >
> > analyze public.ConfigBackup
> >
> > Because ConfigBackup is mixed case it cannot find the relation. I fixed
> > this by going to the function init_table_info and increasing the malloc for
> > new_tbl->table_name by 2 and adding "'s to either side of the table
> > name. Is there anything wrong with this approach? Is there a config I can
> > set to make this non-case sensitive?
> >
> > Thanks again for your time.
> >
> > --- Adam Kavan
> > --- akavan(at)cox(dot)net
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 5: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/docs/faqs/FAQ.html
> >
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-09-10 20:17:02 Re: FK type mismatches?
Previous Message Bruce Momjian 2003-09-10 19:43:51 Re: [BUGS] pg_dump/all doesn't output schemas correctly (v7.3.4)