Re: fix for new SUSET GUC variables

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Aizaz Ahmed <aahmed(at)redhat(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Fernando Nasser <fnasser(at)redhat(dot)com>
Subject: Re: fix for new SUSET GUC variables
Date: 2003-07-21 21:02:27
Message-ID: 200307212102.h6LL2Rb16573@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Aizaz Ahmed <aahmed(at)redhat(dot)com> writes:
> > I believe when updating the GucContext enum, it is also necessary to
> > update the GucContext_names [] in backend/utils/misc/help_config.c.
> > The need to do this was supposed to be added as a comment to the guc.h
> > file, right about where GucContext is defined, but it seems as if that
> > part of the patch was not applied.
>
> I did not include that comment because it seemed misleading (that array
> is far from the only place that has to be adjusted when adding a new
> GucContext value) as well as distracting (GucContext_names is not
> exactly the most important thing to know about when trying to understand
> GucContext).

Comment removed.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-07-21 22:04:18 Re: [GENERAL] [BUGS] pg_tables view definition incorrect??
Previous Message Bruce Momjian 2003-07-21 20:37:15 Re: createlang/droplang fix