Re: Error messages --- now that we've got it, do you like

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Error messages --- now that we've got it, do you like
Date: 2003-07-20 21:39:36
Message-ID: 200307202139.h6KLdaN21230@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


VERBOSE doesn't seem like the right name for the \set parameter. I
consider VERBOSE to be a possible value for error verbosity. Saying
'\set VERBOSE terse' seems like an contradiction.

Should we call it VERBOSITY, or something else? Seems 'error' or 'err'
or 'message' should be in there somewhere too.

Here is a good example of the problem:

> regression=# \set VERBOSE verbose
> regression=# \set VERBOSE default
> regression=# \set VERBOSE terse

That is just confusing. It is the parameter name and a possible value.

How about MESSOUTPUT or ERROUTPUT? Both look ugly, though.

---------------------------------------------------------------------------

Tom Lane wrote:
> First fruits of all that work on error message rejiggering ...
>
> regression=# \set VERBOSE terse
>
> regression=# select 1!! ;
> ERROR: operator does not exist: integer !!
>
> regression=# \set VERBOSE default
>
> regression=# select 1!! ;
> ERROR: operator does not exist: integer !!
> HINT: No operator matches the given name and argument type(s). You may need to add explicit typecasts.
>
> regression=# \set VERBOSE verbose
>
> regression=# select 1!! ;
> ERROR: 42883: operator does not exist: integer !!
> HINT: No operator matches the given name and argument type(s). You may need to add explicit typecasts.
> LOCATION: op_error, parse_oper.c:691
>
> regression=# select 'z' && 'q';
> ERROR: 42725: operator is not unique: "unknown" && "unknown"
> HINT: Unable to choose a best candidate operator. You may need to add explicit typecasts.
> LOCATION: op_error, parse_oper.c:684
>
> Before we go too much further, does this look sane to people?
> Any adjustments you want to make around the edges?
>
> (BTW, if you're wondering where the 42xxx error codes came from,
> I borrowed them from DB2. The SQL99 spec seems happy to lump
> all sorts of conditions under 42000 "syntax error or access
> violation" ...)
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-07-20 21:51:23 Re: Error messages --- now that we've got it, do you like it?
Previous Message Bruce Momjian 2003-07-20 19:32:35 Re: How to submit Tsearch V2 ?