Re: Inherits tables and current CVS

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Nick Barr <nick(dot)barr(at)webbased(dot)co(dot)uk>
Cc: "'Teodor Sigaev'" <teodor(at)sigaev(dot)ru>, pgsql-general-owner(at)postgresql(dot)org, "'pgsql-general'" <pgsql-general(at)postgresql(dot)org>
Subject: Re: Inherits tables and current CVS
Date: 2003-07-20 01:22:28
Message-ID: 200307200122.h6K1MSI01946@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Nick Barr wrote:
> Heya,
>
> I tested against the original version, CVS 1.71.2.1, and it applied
> fine.
>
> ------------------------------------
> [nkd(at)WEBBASED postgresql]$ patch -p0 describe.c <
> describe_inherits_733.diff
> patching file describe.c
> [nkd(at)WEBBASED postgresql]$
> ------------------------------------
>
> Anyway, I have also put together a 7.4 patch, which is attached, CVS
> 1.77. I have tested applying this patch and it also works fine.
>
> Hope that's clearer.
>
>
> Kind Regards,
>
> Nick Barr
> WebBased Ltd.
>
> Tel: (01752) 764445
> Fax: (01752) 764446
> Email: nick(dot)barr(at)webbased(dot)co(dot)uk
>
> This email and any attachments are confidential to the intended
> recipient and may also be privileged. If you are not the intended
> recipient please delete it from your system and notify the sender. You
> should not copy it or use it for any purpose nor disclose or distribute
> its contents to any other person.
>
>
>
> > -----Original Message-----
> > From: Teodor Sigaev [mailto:teodor(at)sigaev(dot)ru]
> > Sent: 26 June 2003 18:42
> > To: Nick Barr
> > Cc: pgsql-general-owner(at)postgresql(dot)org; pgsql-general
> > Subject: Re: Inherits tables and current CVS
> >
> >
> >
> > Nick Barr wrote:
> > > Hi,
> > >
> > > Having read the list, and noticed the message about table
> inheritance I
> > > thought that I would see if I could come up with a simple solution,
> and
> > > have my first delve into the code for PostgreSQL.
> > >
> > > Attached is a diff against 7.3.3 source, of changes to describe.c
> for
> > > psql. This should print out a list of parent tables in a similar
> style
> > > to that of the index listing. I have done some testing on my side
> and it
> > > all seems fine, can some other people have a quick look? What do
> people
> > > think? Useful?
> > Cool!! Thank you. But your patch can't be applyed to current CVS:
> >
> > % patch < ~/describe_inherits.diff
> > Hmm... Looks like a unified diff to me...
> > The text leading up to this was:
> > --------------------------
> > |--- describe.c Sat Dec 21 01:07:22 2002
> > |+++ describe_inherits.c Thu Jun 26 18:05:17 2003
> > --------------------------
> > Patching file describe.c using Plan A...
> > Hunk #1 succeeded at 928 (offset -13 lines).
> > Hunk #2 failed at 1021.
> > Hunk #3 succeeded at 1159 with fuzz 1 (offset 7 lines).
> > Hunk #4 succeeded at 1162 (offset -13 lines).
> > 1 out of 4 hunks failed--saving rejects to describe.c.rej
> >
> >
> >
> > --
> > Teodor Sigaev E-mail:
> teodor(at)sigaev(dot)ru

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2003-07-20 03:56:20 Re: Urgent: 10K or more connections
Previous Message Arcadius A. 2003-07-19 22:56:50 Re: Help with privilege or pg_hba.conf