| From: | Kurt Roeckx <Q(at)ping(dot)be> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Philip Yarra <philip(at)utiba(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org, Samuel A Horwitz <horwitz(at)argoscomp(dot)com> |
| Subject: | Re: OSF build fixed |
| Date: | 2003-07-15 20:14:38 |
| Message-ID: | 20030715201438.GA3884@ping.be |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 15, 2003 at 01:56:55PM -0400, Tom Lane wrote:
> Philip Yarra <philip(at)utiba(dot)com> writes:
> > int64-pqcomm.patch: changes int64_t to int64 in src/include/libpq/pqcomm.h
> > tested on RedHat Linux 7.3 and OSF
>
> Applied (along with some further hacking to make the struct padding
> logic more robust).
I'm not sure what you did exactly, or why you think it's better.
But it seems you removed the "6 byte pad", between the
ss_family and the __ss_align, and I have no idea why.
I won't say that I fully understand allignment as is defined in
the C standard(s), but I do know that it doesn't have to allign
an int64 to a multiple of 8 byte address.
Note that I didn't just make that structure up, other people did.
It's for instance like that in the RFC and in SUS v3.
Kurt
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ivan | 2003-07-15 20:16:05 | perm question |
| Previous Message | Tom Lane | 2003-07-15 20:03:13 | Re: problems with pg_restore |