Re: Small perf fixes/cleanup in src/backend/utils/adt/like.c...

From: Sean Chittenden <sean(at)chittenden(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Small perf fixes/cleanup in src/backend/utils/adt/like.c...
Date: 2003-06-23 17:35:55
Message-ID: 20030623173555.GZ97131@perrin.int.nxad.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> > While doing some review of the LIKE function, I noticed some useless
> > bits left over from the pre-MB and converting-MB world.
>
> Isn't this patch going to destroy performance in single-byte
> encodings? I don't think the present state of the LIKE code is an
> intermediate state --- it's exactly where we want it to be.

cpp is my friend. I get how this was working now: didn't notice the
2nd #include "like_match.c" earlier and thought all definitions of
MatchText and MBMatchText were the same. Tricky with the macro
expansion and redefinitions. -sc

--
Sean Chittenden

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Sean Chittenden 2003-06-23 18:23:42 Re: Patch to be verbose about being unable to read ~/.pgpasss...
Previous Message Tom Lane 2003-06-23 17:24:11 Re: Patch to be verbose about being unable to read ~/.pgpasss...