Re: Adding Rendezvous support to postmaster

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chris Campbell <chris(at)bignerdranch(dot)com>
Subject: Re: Adding Rendezvous support to postmaster
Date: 2003-06-11 14:43:11
Message-ID: 200306111443.h5BEhBP21481@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > I also _didn't_ add the Rendezvous GUC variable, so we default to the
> > > host name. If there is need, we can add it later.
> >
> > How do you figure there is not need for it? What about running more
> > than one postmaster at a time?
>
> No one brought up that idea, and Chris agreed we could try it without
> it. Chris, is that an issue? I see the port number in the Rendezvous
> function call:
>
> if (service_name != NULL)
> {
> DNSServiceRegistrationCreate(NULL, /* default to hostname */
> "_postgresql._tcp.",
> "",
> htonl(PostPortNumber),
> "",
> (DNSServiceRegistrationReply)reg_reply,
> NULL);

Two more issues --- first, I changed 'pgsql' to 'postgresql' as the
service name, to match our registered TCP service name. Second, if we
do add a GUC variable, it has to conditionally be included in
postgresql.conf.sample if Rendezvous is enabled.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-06-11 15:02:27 Re: FK on update no action patch
Previous Message Greg Sabino Mullane 2003-06-11 14:35:29 perform.sgml update