Re: Win32 path patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 path patch
Date: 2003-04-04 20:13:49
Message-ID: 200304042013.h34KDnO14375@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, here is a new patch. I moved the path.o inclusion into
Makefile.global. I couldn't put it in port/Makefile because
interfaces/libpq/Makefile looks at LIBOBJ too.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > The patch is 700 lines, but adds only two WIN32's to the code. The
> > majority of the work is done in port/path.c. While /port was for
> > port-specific stuff, in this case, it seems like the best place to put
> > functions that are used by both the backend and interfaces/clients.
>
> But there is no reason to write AC_LIBOBJ(path) unconditionally in
> configure.in. Just handle it in the Makefile.
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 20.6 KB

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-04-04 20:39:21 Re: system() patch for Win32
Previous Message Alvaro Herrera 2003-04-04 02:57:22 Re: pglog-rotator