Re: to_char PL/MI fix

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: to_char PL/MI fix
Date: 2003-03-20 06:17:22
Message-ID: 200303200617.h2K6HMI17084@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


This patch caused the following regression failures. Is the new output
valid?

---------------------------------------------------------------------------

Karel Zak wrote:
>
>
> Peter found bug in the to_char() routine for PL/MI options. This
> patch fix it -- but this patch doesn't contains tests or docs fixes. I
> will send it later.
>
> Fixed outputs:
>
> select to_char(x, '9999.999') as x,
> to_char(x, 'S9999.999') as s,
> to_char(x, 'SG9999.999') as sg,
> to_char(x, 'MI9999.999') as mi,
> to_char(x, 'PL9999.999') as pl,
> to_char(x, 'PLMI9999.999') as plmi,
> to_char(x, '9999.999SG') as sg2,
> to_char(x, '9999.999PL') as pl2,
> to_char(x, '9999.999MI') as mi2 from num;
>
> x | s | sg | mi | pl |
> -----------+-----------+-----------+-----------+------------+
> 123.000 | +123.000 | + 123.000 | 123.000 | + 123.000 |
> -123.000 | -123.000 | - 123.000 | - 123.000 | -123.000 |
> -1231.000 | -1231.000 | -1231.000 | -1231.000 | -1231.000 |
> 1231.000 | +1231.000 | +1231.000 | 1231.000 | + 1231.000 |
> 1.900 | +1.900 | + 1.900 | 1.900 | + 1.900 |
> -1.900 | -1.900 | - 1.900 | - 1.900 | -1.900 |
> -.900 | -.900 | - .900 | - .900 | -.900 |
> .900 | +.900 | + .900 | .900 | + .900 |
> .945 | +.945 | + .945 | .945 | + .945 |
> -.945 | -.945 | - .945 | - .945 | -.945 |
> -150.945 | -150.945 | - 150.945 | - 150.945 | -150.945 |
> 150.945 | +150.945 | + 150.945 | 150.945 | + 150.945 |
>
> | plmi | sg2 | pl2 | mi2
> +------------+-----------+------------+-----------
> | + 123.000 | 123.000+ | 123.000+ | 123.000
> | - 123.000 | 123.000- | -123.000 | 123.000-
> | -1231.000 | 1231.000- | -1231.000 | 1231.000-
> | + 1231.000 | 1231.000+ | 1231.000+ | 1231.000
> | + 1.900 | 1.900+ | 1.900+ | 1.900
> | - 1.900 | 1.900- | -1.900 | 1.900-
> | - .900 | .900- | -.900 | .900-
> | + .900 | .900+ | .900+ | .900
> | + .945 | .945+ | .945+ | .945
> | - .945 | .945- | -.945 | .945-
> | - 150.945 | 150.945- | -150.945 | 150.945-
> | + 150.945 | 150.945+ | 150.945+ | 150.945
>
>
> Karel
>
>
> --
> Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
> http://home.zf.jcu.cz/~zakkr/

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 4.8 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-03-20 06:23:36 Re: PGRES_POLLING_ACTIVE is unused...
Previous Message Bruce Momjian 2003-03-20 06:02:50 Re: Patch to fix horology regression failure