Re: PGRES_POLLING_ACTIVE is unused...

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Lennert Buytenhek <buytenh(at)gnu(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: PGRES_POLLING_ACTIVE is unused...
Date: 2003-03-17 19:57:10
Message-ID: 200303171957.h2HJvAM19554@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


This change will be made to the poll patch:

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Tom Lane wrote:
> Lennert Buytenhek <buytenh(at)gnu(dot)org> writes:
> > ...any reason why it is there at all?
>
> Good question. Some digging in CVS shows that it was unused even in the
> patch that introduced it, and never has been used in any release since.
> So it does seem like useless complication.
>
> However, I think it'd be unwise to remove the constant from libpq-fe.h,
> because that would break the application of any poor sod who believed
> the documentation and wrote code that actually checks for
> PGRES_POLLING_ACTIVE.
>
> I'd be inclined to remove it from the documentation and the library
> innards, but leave something like this in libpq-fe.h:
>
> PGRES_POLLING_ACTIVE /* unused; keep for awhile for
> * backwards compatibility */
>
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-03-17 21:36:36 Re: XML ouput for psql
Previous Message Bruce Momjian 2003-03-17 19:56:53 Re: PGRES_POLLING_ACTIVE is unused...