Re: Bug #902: Build problems with 7.3.1 and 7.3.2 on SunOS (crypt.h)

Patch attached and applied. Thanks. Should I backpatch to 7.3.X? Is it
safe?

---------------------------------------------------------------------------

pgsql-bugs(at)postgresql(dot)org wrote:
> Fred Houweling (fred(at)fh(dot)dropbear(dot)id(dot)au) reports a bug with a severity of 3
> The lower the number the more severe it is.
>
> Short Description
> Build problems with 7.3.1 and 7.3.2 on SunOS (crypt.h) + Solution
>
> Long Description
> Hi,
> As per request from Justin Clift [justin(at)postgresql(dot)org](dot)
> I think I have found a small issue,
>
> During build at fe-connect.c the following errors occur:
> gcc -L/spare1/local/lib -I/spare1/local/include -Wall -Wmissing-prototypes -Wmissing-declarations -fPIC -I. -I../../../src/include -I/spare1/local/include -DFRONTEND -DSYSCONFDIR='"/spare1/local/etc/postgresql"' -c -o fe-connect.o fe-connect.c
> In file included from fe-connect.c:47:
> /usr/include/crypt.h:22: parse error before `('
> /usr/include/crypt.h:22: parse error before `const'
> gmake: *** [fe-connect.o] Error 1
>
> I found that reordering the includes in fe-connect.c as bellow fixes the problem, (I uses fe-auth.c as a guide, which compiles ok)
>
> #ifdef HAVE_CRYPT_H
> #include <crypt.h>
> #endif
>
> #include "libpq-fe.h"
> #include "libpq-int.h"
> #include "fe-auth.h"
>
> uname -a
> SunOS hostname 5.8 Generic_108528-13 sun4u sparc SUNW,Ultra-5_10
>
> gcc -v
> Reading specs from /usr/local/lib/gcc-lib/sparc-sun-solaris2.8/2.95.3/specs
> gcc version 2.95.3 20010315 (release)
>
> Also
> I am linking in OpenSSL 0.9.7,
> I also viewed the Solaris version of this include <crypt.h> and have found that there is nothing wrong with it.
>
> side note:
> Reading this url is mandatory on this platform.
> http://techdocs.postgresql.org/installguides.php#solaris
>
> Thanks
>
> Fred Houweling
> fred(at)fh(dot)dropbear(dot)id(dot)au
>
> Sample Code
> #ifdef HAVE_CRYPT_H
> #include <crypt.h>
> #endif
>
> #include "libpq-fe.h"
> #include "libpq-int.h"
> #include "fe-auth.h"
>
>
> No file was uploaded with this report
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073