psql patch (2)

From: "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: psql patch (2)
Date: 2003-02-27 18:07:50
Message-ID: 20030227180750.GA26730@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

I'm continuing to work on cleaning up code in psql. As things appear
now, my changes seem to work. Some possible minor bugs got squished
on the way but I can't be sure without more feedback from people who
really put the code to the test.

The new patch mostly simplifies variable handling and reduces code
duplication. Changes in the command parser eliminate some redundant
variables (boolean state + depth counter), replaces some
"else if" constructs with switches, and so on. It is meant to be
applied together with my previous patch, although I hope they don't
conflict; I went back to the CVS version for this one.

One more thing I thought should perhaps be changed: an IGNOREEOF
value of n will ignore only n-1 EOFs. I didn't want to touch this
for fear of breaking existing applications, but it does seem a tad
illogical.

Jeroen

Attachment Content-Type Size
psql.patch2 text/plain 27.6 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2003-02-27 19:33:21 Re: [HACKERS] loading libraries on Postmaster startup
Previous Message Ross J. Reedstrom 2003-02-27 16:31:01 Re: [HACKERS] Simplifying timezone support