Re: pgsql-server/src/backend commands/sequence.c p ...

I am not thrilled to see those huge integers in the dump file for
sequences. It would be good to test for these in pg_dump and output
those symbols instead. i don't think we need to store them as bools ---
just make the tests to see if the values matches these symbol values.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.
> On Thu, 2003-02-13 at 02:21, Christopher Kings-Lynne wrote:
> > Shouldn't this patch need some pg_dump changes? And doc changes? Maybe
> > even psql changes?
> >
> > How is NO MAXVALUE and NO MINVALUE stored in the database? How are they
> > recreated that way after a dump?
>
> They're not stored. According to the spec they're simply aliases to the
> default values, as such we store the default values.
>
> I suppose if you wanted to make the dump portable to other databases one
> could store bools for these.
>
> > > -----Original Message-----
> > > From: pgsql-committers-owner(at)postgresql(dot)org
> > > [mailto:pgsql-committers-owner(at)postgresql(dot)org]On Behalf Of Bruce Momjian
> > > - CVS
> > > Sent: Thursday, 13 February 2003 1:25 PM
> > > To: pgsql-committers(at)postgresql(dot)org
> > > Subject: [COMMITTERS] pgsql-server/src/backend commands/sequence.c p ...
> > >
> > >
> > > CVSROOT: /cvsroot
> > > Module name: pgsql-server
> > > Changes by: momjian(at)postgresql(dot)org 03/02/13 00:25:25
> > >
> > > Modified files:
> > > src/backend/commands: sequence.c
> > > src/backend/parser: gram.y
> > >
> > > Log message:
> > > Adds in NO MAXVALUE and NO MINVALUE options for create
> > > sequence per 200X
> > > spec, which will also make alter sequence a touch easier.
> > >
> > > sequence.c init_params() will check for settings which have been
> > > defined twice, and complain.
> > >
> > > Rod Taylor
> > >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 6: Have you searched our list archives?
> > >
> > > http://archives.postgresql.org
> > >
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> --
> Rod Taylor <rbt(at)rbt(dot)ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc
-- End of PGP section, PGP failed!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073